Two UI bugs

1. Lightbox closes when clicking outside of its contents. This is extremely aggravating, as it can easily cause data loss. IIRC, there's an option you can pass to the lightbox to prevent clicking outside of the lightbox to cause it to close, and IMHO that option should be the default - particularly since ESC is already bound to the close window event.

2. Up/Down Arrow keys don't work in the code editor box when editing events. I'm running Chrome on linux, I haven't tested yet in any other browsers. The workaround is to use Home/End/Left/Right, but it's rather unpleasant.

Hi cr33,

Thank you for posting this!

#1- Unfortunately I couldn't find a SqueezeBox setting to disable closure when clicked outside the box😟

#2- yes, I know about this issue, but can't find the reason for it to be able to fix it, I hope I will be able to find that sometime soon.

Regards,
Max

#1- Unfortunately I couldn't find a SqueezeBox setting to disable closure when clicked outside the box😟

Comment out line 254 in Squeezebox.js:

//		this.overlay[fn]('click', this.bound.close);

Or if you will be maintaining this version of squeezebox inside chronoforms, you can add your own parameter at the top and check against it in the toggleListeners function.

I've had no luck tracking down #2.

Chris

Thanks Chris!🙂

Max

That arrow up/down problem is very annoying and I just figured out the problem.

Around line 287 in Squeezebox.js you will find this:

onKey: function(e) {
		switch (e.key) {
			case 'esc': this.close(e);
			case 'up': case 'down': return false;
		}
	},

For some very odd reason squeezebox prevents the up and down keys from working. I have commented the line out and now the up and down arrows works fine. I really can't imagine why the f... someone would like to do that, but none the less the code is thereface-meh-blank

Thank you very much for this super fix!🙂

Best regards,
Max