Forums

XHTML validation bug

dynedain 28 Feb, 2007
Generated forms with javascript are not XHTML compliant because the <script> tag is missing an attribute.

To fix, simply replace line 20 of chronocontact.html.php

		echo "<script>";


With:


		echo "<script type='text/javascript'>"



Also, the error message in the same document (line 42)

		echo "There is no form with this name, plz check the url and the form management";


is extremely unprofessional. Please replace "plz" with "please".
dynedain 28 Feb, 2007
I recommend that the script output section of chronocontact.html.php be replaced with:

		<?php if(!empty($rows[0]->scriptcode)){ 
		echo "<script type='text/javascript'>\n";
		echo "//<![CDATA[\n";
		echo $rows[0]->scriptcode;
		echo "//]]>\n";
		echo "</script>\n";			
		}		
		?>


Also, the actionurl output should be replaced as follows:

$actionurl = 'index.php?option=com_chronocontact&task=send&chronoformname='.$rows[0]->name;

(notice using & instead of &«»)
Max_admin 06 Mar, 2007
Thanky ou very much for ur suggestions dynedain, these changes will be tested and applied in the next release.;)

Thanks,

Max
Max, ChronoForms developer
ChronoMyAdmin: Database administration within Joomla, no phpMyAdmin needed.
ChronoMails simplifies Joomla email: newsletters, logging, and custom templates.
This topic is locked and no more replies can be posted.