I am not sure if this have been discussed before, or if it is possible already, but anyway:
I have set my latest comment module to limit the body to 35 (or something), but still it happens that people manage to sneak in a linebreak before that, and the linebreak will also show up in the latest comment module. I was wondering if it was possible to implement a setting like Ignore linebreak or stop at linebreak, so that it won't look like this:
[attachment=0]comment.png[/attachment]
I have set my latest comment module to limit the body to 35 (or something), but still it happens that people manage to sneak in a linebreak before that, and the linebreak will also show up in the latest comment module. I was wondering if it was possible to implement a setting like Ignore linebreak or stop at linebreak, so that it won't look like this:
[attachment=0]comment.png[/attachment]
Hi Magnus,
you can do this by a simple hack to the module file, before this line:
add:
Cheers
Max
you can do this by a simple hack to the module file, before this line:
$all_comments .= $current_comment_item;
add:
$current_comment_item = str_replace("<br>", "", $current_comment_item);
Cheers
Max
I did that. so now it looks like:
But that prevents the comments from appearing as a list:
[attachment=0]com.png[/attachment]
Did I do something wrong? I can be pretty stupid with these things..
$current_comment_item = str_replace("<br>", "", $current_comment_item);
$all_comments .= $current_comment_item;
But that prevents the comments from appearing as a list:
[attachment=0]com.png[/attachment]
Did I do something wrong? I can be pretty stupid with these things..
please show me the comment element format in the module config, it should have <br> at the end, change it to <br />
Regards
Max
Regards
Max
Friday the 13th and all, once I try something out in the 14th it works. I really need to write up a review for you guys at JED, and see if I can afford the subscription some time soon.
Or that brings me back to my original issue:
[attachment=0]com.png[/attachment]
Or that brings me back to my original issue:
[attachment=0]com.png[/attachment]
Thanks Magnus, please show me the module configuration code you changed, this is the only change you made since you had all lines together ?
Max
Max
What I have done so far:
1. Added the code to helper.php (I think it was, sorry, my memory isn't too good)
2. Changed <br> to <br /> in module configuration
My module configuration, comment row content. Tried adding <br /> back but it keeps disappearing after I save it?
1. Added the code to helper.php (I think it was, sorry, my memory isn't too good)
2. Changed <br> to <br /> in module configuration
<a href="{page_link}#commentID{id}">{text}...</a>
My module configuration, comment row content. Tried adding <br /> back but it keeps disappearing after I save it?
Hi Magnus,
I don't see neither <br> nor <br /> in the code line! you needed <br /> at the end! backup this line then completely remove it and Apply, what do you get as a result ?
Max
2. Changed <br> to <br /> in module configuration
I don't see neither <br> nor <br /> in the code line! you needed <br /> at the end! backup this line then completely remove it and Apply, what do you get as a result ?
Max
Removing it results in no comments being shown. If I change it to <br> it will put all comments on one line, instead of each comment on a separate line. If I change it to <br /> it will just remove it when I save it, and when I open it again it will be the line I posted above.
As when I try to save:
It saves OK, but when I open the module configuration page again it shows:
As when I try to save:
<a href="{page_link}#commentID{id}">{text}...</a><br />
It saves OK, but when I open the module configuration page again it shows:
<a href="{page_link}#commentID{id}">{text}...</a>
Hi Magnus,
This is weird, why its removed, lets try another way!
use this :
let me know!
Cheers
Max
This is weird, why its removed, lets try another way!
use this :
<p><a href="{page_link}#commentID{id}">{text}...</a></p>
let me know!
Cheers
Max
</p> brings about the same problem as <br>, all in one line. But adding <br /> at the end seems to move them to separate lines, even though it is gone the next time I open the module configuration screen. Still isn't working with the line break though. Doesn't matter too much to me, just a feature that would be nice to add in the module.
Hi Magnus,
That's Ok, I will copy this to the bugs forums and check it on time!
Cheers
Max
That's Ok, I will copy this to the bugs forums and check it on time!
Cheers
Max
Hi Max & Magnus,
Try using a div container. My config looks like this with a body text limit of 25:
You can remove the horizontal rule tag if you don't want a line separator. You can also change the bottom margin spacing and font color to suit your template.
Aloha,
warriorgov79
Try using a div container. My config looks like this with a body text limit of 25:
<div style="margin-bottom:7px;">{datetime}
<span style="font-weight:bold; color:#444444;">{name}:</span> <a href="{page_link}#commentID{id}">{text}…</a></div>
<hr />
You can remove the horizontal rule tag if you don't want a line separator. You can also change the bottom margin spacing and font color to suit your template.
Aloha,
warriorgov79
good idea!
Max
Max
This topic is locked and no more replies can be posted.